-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone the PR's merge branch vs head in e2e tests #483
base: main
Are you sure you want to change the base?
Conversation
So, this might fix 482 but it's one of those things we won't know until we merge it and see what happens. I tested this manually in a separate PR and it fixed things, but testing these changes manually involves changing the trigger conditions for the workflows and doing that can influence the exact ref checked out by actions/checkout. This definitely fixes the issue for anything use |
After spelunking in the GitHub actions/checkout repo, it appears that when using |
This configures actions/checkout to clone the PR's merge branch (instead of the PR's head), to align with how unit/functional tests work and ensure that all of our tests are testing against the same codebase - the state of the code as it would look after the PR merges, to get an accurate picture of whether things will pass if this merges or not. Fixes instructlab#482 Signed-off-by: Ben Browning <[email protected]>
d17bb74
to
b1979c6
Compare
Ok, this is ready for review. The tldr of this change is that instead of checking out Note that the default behavior of |
This configures actions/checkout to clone the PR's merge branch (instead of the PR's head), to align with how unit/functional tests work and ensure that all of our tests are testing against the same codebase - the state of the code as it would look after the PR merges, to get an accurate picture of whether things will pass if this merges or not.
Related to #482