Update URLs in docs/dataset_formats.md to point to the new InstructLab scripts/test-data files
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repo structure was modified in `instructlab/instructlab`, so we need to update the URLs to coincide with that change. Also, we need to add `mbta` to the spellcheck dictionary because the PR build checks think that `mbta` is a misspelled word. Signed-off-by: Courtney Pacheco <[email protected]>
courtneypacheco
force-pushed
the
update-dataset-format-doc
branch
from
6f82fe5 to
6397b6e
Compare
mergify
bot
added
CI/CD
danmcp
reviewed
Dec 11, 2024
| * [e2e-qna-freeform-skill](https://github.com/instructlab/instructlab/blob/main/scripts/test-data/e2e-qna-freeform-skill.yaml) | ||
| * [e2e-qna-grounded-skill](https://github.com/instructlab/instructlab/blob/main/scripts/test-data/e2e-qna-grounded-skill.yaml) | ||
| * [e2e-qna-knowledge](https://github.com/instructlab/instructlab/blob/main/scripts/test-data/e2e-qna-knowledge.yaml) | ||
| * Compositional skills |
There was a problem hiding this comment.
Changes look good, my only question is whether we want to list all of the them. Should we just refer to the directories now?
There was a problem hiding this comment.
I was wondering that too, especially if we start adding even more YAMLs over time. (Could make for a lengthy list.)
Also, the new sub-directory names are pretty self explanatory IMO.
I'm open to either approach
bbrowning
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Just a small issue with one broken link we should fix, but thanks for updating this!
Longer-term I'd like to probably just link to the core or taxonomy repos for any/all discussion of the taxonomy format, but that is probably best done once we move preprocessing out of SDG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scripts/test-datadirectory structure was modified in the instructlab/instructlab repo to accommodate more skill + knowledge files, which means we need to update thescripts/test-dataURLs indocs/dataset_formats.mdaccordingly.