fix: Restrict docling library versions to resolve dependency issues + update mypy linting packages
#434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrowning
approved these changes
Dec 10, 2024
|
Staging this for backport to the 0.6.x branch as well, as we'll need to cut a release with this change to fix CI as well as users installing SDG (and InstructLab) on a fresh system. @Mergifyio backport release-v0.6 |
courtneypacheco
force-pushed
the
fix-docling-parse-issue
branch
from
aeaf94e to
f95f706
Compare
mergify
bot
added
CI/CD
`docling-parse` v3.0.0 contains breaking changes to the syntax, which is currently breaking our builds. Also, `mypy` < v1.14 pulls in the latest version of `pydantic` by default, so this commimt hardcodes the correct span of `pydantic` versions that are compatible with `mypy` < v1.14 Finally, we want to pin `docling[tesserocr]>=2.4.2,<=2.8.3` due to breaking changes in v2.9.0 on 9 Dec 2024. Signed-off-by: Courtney Pacheco <[email protected]>
courtneypacheco
force-pushed
the
fix-docling-parse-issue
branch
from
f95f706 to
2e00bb8
Compare
|
@courtneypacheco Would you mind editing the top message /title of the PR a bit to reflect the additional changes? Thanks! |
|
Oh, you already did, seemingly between when I decided to ask you to and when I typed that. Thanks for reading my mind! |
courtneypacheco
changed the title
docling-parse>=2.0.0,<3.0.0 to resolve breaking issues from v3docling library versions to resolve dependency issues + update mypy linting packages
|
@Mergifyio backport release-v0.6 |
✅ Backports have been created
|
bbrowning
added a commit
that referenced
this pull request
Dec 10, 2024
fix: Restrict `docling` library versions to resolve dependency issues + update `mypy` linting packages (backport #434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Resolves #439
docling-parseis automatically pulled in bydoclingas a dependency, and v3.0.0 ofdocling-parsecontains breaking syntax changes that prevent our e2e builds ininstructlabfrom succeeding. See issue in InstructLab here: instructlab/instructlab#2765For now, we will pin
docling-parseto the latest v2 release while we investigate how we can update thedocling-parsesyntax to use the new v3 syntax. We will also pin todocling<=2.8.3because v2.10.0 was updated to usedocling-parse>=3.0.0. See here: https://github.com/DS4SD/docling/releases/tag/v2.10.0 (Docling-parse v2 as default PDF backend)Finally,
mypyis experiencing issues with a breaking upstream change, too. By default,mypypulls in the latest version ofpydantic, which is unfortunately now incompatible withmypyas of its v2.10 release. See:mypytype-checking issues affecting aField'sdefaultvalue ordefault_factoryafter upgrade to 2.10 pydantic/pydantic#10950To workaround this dependency issue, I pinned the related dependency,
pydantic, to<=v2.9.2in ourtox.inifile. This will force our latestmypyto use a compatiblepydantic. However, note that I did also pinmypy>=1.0,<1.14. I did this as a safety measure for when themypymaintainers inevitably fix the issue in v1.14 or later.