Refactor Document Chunker to always use docling #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobotSail
reviewed
Dec 6, 2024
RobotSail
reviewed
Dec 6, 2024
aakankshaduggal
force-pushed
the
ks-chunking-refactor
branch
from
f62567d to
309fd11
Compare
aakankshaduggal
force-pushed
the
ks-chunking-refactor
branch
from
c84fa40 to
d4cc458
Compare
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
|
e2e workflow succeeded on this PR: View run, congrats! |
bbrowning
reviewed
Jan 9, 2025
khaledsulayman
force-pushed
the
ks-chunking-refactor
branch
from
3e0eed7 to
ff40438
Compare
Signed-off-by: Khaled Sulayman <[email protected]>
Signed-off-by: Khaled Sulayman <[email protected]>
Signed-off-by: Khaled Sulayman <[email protected]>
Signed-off-by: Khaled Sulayman <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Khaled Sulayman <[email protected]>
Signed-off-by: Khaled Sulayman <[email protected]>
khaledsulayman
force-pushed
the
ks-chunking-refactor
branch
from
ff40438 to
a692d70
Compare
Signed-off-by: Khaled Sulayman <[email protected]>
khaledsulayman
force-pushed
the
ks-chunking-refactor
branch
from
2b122f1 to
e3a3e1e
Compare
aakankshaduggal
approved these changes
Jan 15, 2025
bbrowning
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old DocumentChunker was a factory class that called the text-splitter on markdowns and docling on PDFs. In reality, we want to call docling and then use the text-splitter on all document types. This change refactors the DocumentChunker class to always call docling (as long as the provided documents are supported filetypes).
Resolves: #334