Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple and full knowledge pipeline functional tests #367

Closed
wants to merge 2 commits into from
Closed

Add simple and full knowledge pipeline functional tests #367

wants to merge 2 commits into from

Conversation

bbrowning
Copy link
Contributor

This takes the old test_knowledge.py manual test script and ports it into simple and full knowledge pipeline functional tests. Note that this is a draft because these tests take a while (over 10 minutes on my machine), so likely need to consider GPU-accelerating them and moving them over to the e2e runners or new runners. All that TBD, but checkpointing work here to park it for a bit while working on something else.

@mergify mergify bot added testing Relates to testing ci-failure dependencies Pull requests that update a dependency file CI/CD Affects CI/CD configuration and removed ci-failure labels Nov 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @bbrowning please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 14, 2024
@mergify mergify bot removed the needs-rebase label Nov 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @bbrowning please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 20, 2024
@bbrowning bbrowning mentioned this pull request Nov 26, 2024
Open
@mergify mergify bot removed the needs-rebase label Jan 6, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. @bbrowning please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 6, 2025
@bbrowning
Add simple and full knowledge pipeline functional tests
8b86c75 
This is a port of the old `scripts/test_knowledge.py` into functional
tests that we can run with CI. These tests take longer, so are marked as
`slow` in pytest.

Signed-off-by: Ben Browning <[email protected]>
@bbrowning
Add a new py3-functional-gpu workflow and tox env
6d399f2 
This runs our functional tests that require a GPU as a separate
workflow item, since they are not the instructlab e2e tests and also
are not the CPU-only unit or functional tests that run in the GitHub runners.

Signed-off-by: Ben Browning <[email protected]>
@mergify mergify bot removed the needs-rebase label Jan 7, 2025
@bbrowning
Copy link
Contributor Author

Closing in favor of #466 since I need to create a PR from a branch in this repo (as opposed to my fork) to test the new GitHub workflow file in the PR.

@bbrowning bbrowning closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD Affects CI/CD configuration ci-failure dependencies Pull requests that update a dependency file testing Relates to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bbrowning