Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Maintainers to be Triagers #347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Require Maintainers to be Triagers #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CONTRIBUTOR_ROLES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,13 @@ Maintainers will vote publicly on the issue, expressing their support via a GitH

After a [decision has been made](https://github.com/instructlab/community/blob/main/governance.md#decision-making-at-the-instructlab-org-level), a Maintainer will create a PR to add you in the [MAINTAINER file](https://github.com/instructlab/community/blob/main/MAINTAINERS.md) within three weeks.

All Maintainers are Triagers. If a candidate is not a Triager at the time of the nomination, they should be added to both Triagers and Maintainers teams.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this saying that you can nominate a user to be a maintainer without them serving as a triager? Does this circumvent the contributor ladder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the ladder should be - at least as a rule - followed in steps. But.

AFAIU nothing in the ladder or this document forbids this from happening now. See the line 102 - the only thing required is being a Member for a month. If we think a Triager requirement (time-bound or a general one) is needed, we can update the document to reflect it accordingly, but that is not the goal of this PR. The goal here is to make sure that Maintainers are always Triagers.


#### Maintainer responsibilities and Privileges

As a project Maintainer, you have the following responsibilities and privileges:
All Maintainers are Triagers and share all of the appropriate [responsibilities and privileges](#triager-responsibilities-and-privileges).

In addition, as a project Maintainer, you have the following responsibilities and privileges:

* You make and approve technical design decisions.
* You set technical direction and priorities.
Expand Down