[Refactor] Remover dependência do Modular ChatMainTalksPage
#395
+145
−31
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,10 @@ class SupportCenterModule extends WidgetModule { | |
|
|
||
| @override | ||
| Widget get view => SupportCenterPage( | ||
| controller: SupportCenterController( | ||
| supportCenterUseCase: SupportCenterUseCase( | ||
| locationService: Modular.get<ILocationServices>(), | ||
| supportCenterRepository: SupportCenterRepository( | ||
| apiProvider: Modular.get<ApiProvider>()))), | ||
|
Comment on lines
+53
to
+57
There was a problem hiding this comment. Não entendi a necessidade de alterar este código, não entendi a relação desta alteração com o PR |
||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import 'package:dartz/dartz.dart' show right, left; | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_modular/flutter_modular.dart'; | ||
| import 'package:flutter_modular_test/flutter_modular_test.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
@@ -12,27 +13,23 @@ import 'package:penhas/app/features/chat/domain/entities/chat_channel_entity.dar | |
| import 'package:penhas/app/features/chat/domain/entities/chat_channel_open_entity.dart'; | ||
| import 'package:penhas/app/features/chat/domain/entities/chat_user_entity.dart'; | ||
| import 'package:penhas/app/features/chat/domain/repositories/chat_channel_repository.dart'; | ||
| import 'package:penhas/app/features/chat/presentation/pages/chat_assistant_card.dart'; | ||
| import 'package:penhas/app/features/chat/presentation/pages/chat_channel_card.dart'; | ||
| import 'package:penhas/app/features/chat/presentation/talk/chat_main_talks_controller.dart'; | ||
| import 'package:penhas/app/features/chat/presentation/talk/chat_main_talks_page.dart'; | ||
|
|
||
| import '../../../../../utils/golden_tests.dart'; | ||
|
|
||
| void main() { | ||
| group(ChatMainTalksPage, () { | ||
| late IChatChannelRepository mockRepository; | ||
| late IModularNavigator mockNavigator; | ||
| late ChatMainTalksController controller; | ||
| setUp(() { | ||
| mockRepository = _MockChatChannelRepository(); | ||
| Modular.navigatorDelegate = mockNavigator = _MockModularNavigate(); | ||
| controller = | ||
| ChatMainTalksController(chatChannelRepository: mockRepository); | ||
|
|
||
| when(() => mockRepository.listChannel()).thenAnswer( | ||
| (_) async => right(_chatChannelAvailableFixture), | ||
|
|
@@ -42,13 +39,17 @@ void main() { | |
| screenshotTest( | ||
| 'loaded state should be rendered', | ||
| fileName: 'chat_main_talks_page_initial_state', | ||
| pageBuilder: () => ChatMainTalksPage( | ||
| controller: controller, | ||
| ), | ||
| ); | ||
|
|
||
| screenshotTest( | ||
| 'error state should be rendered', | ||
| fileName: 'chat_main_talks_page_error_state', | ||
| pageBuilder: () => ChatMainTalksPage( | ||
| controller: controller, | ||
| ), | ||
| setUp: () { | ||
| when(() => mockRepository.listChannel()).thenAnswer( | ||
| (_) async => left(ServerFailure()), | ||
|
|
@@ -60,7 +61,9 @@ void main() { | |
| 'should navigate to assistant quiz when open assistant card', | ||
| (tester) => mockNetworkImages(() async { | ||
| // arrange | ||
| final widget = buildTestableWidget(ChatMainTalksPage( | ||
| controller: controller, | ||
| )); | ||
| await tester.pumpWidget(widget); | ||
| await tester.pumpAndSettle(); | ||
| when( | ||
|
|
@@ -89,7 +92,9 @@ void main() { | |
| 'should navigate to support chat when open support card', | ||
| (tester) => mockNetworkImages(() async { | ||
| // arrange | ||
| final widget = buildTestableWidget(ChatMainTalksPage( | ||
| controller: controller, | ||
| )); | ||
| await tester.pumpWidget(widget); | ||
| await tester.pumpAndSettle(); | ||
| when( | ||
|
|
@@ -117,7 +122,9 @@ void main() { | |
| 'should navigate to chat page when open conversation card', | ||
| (tester) => mockNetworkImages(() async { | ||
| // arrange | ||
| final widget = buildTestableWidget(ChatMainTalksPage( | ||
| controller: controller, | ||
| )); | ||
| await tester.pumpWidget(widget); | ||
| await tester.pumpAndSettle(); | ||
| when( | ||
|
|
@@ -139,6 +146,86 @@ void main() { | |
| ).called(1); | ||
| }), | ||
| ); | ||
|
|
||
| testWidgets( | ||
| 'should display loading state', | ||
| (tester) => mockNetworkImages(() async { | ||
| // arrange | ||
| when(() => mockRepository.listChannel()).thenAnswer( | ||
| (_) async => right(_chatChannelAvailableFixture), | ||
| ); | ||
| // act | ||
| await tester.pumpWidget( | ||
| MaterialApp( | ||
| home: ChatMainTalksPage(controller: controller), | ||
| ), | ||
| ); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| // Assert | ||
| expect(find.byType(ChatChannelCard), findsNWidgets(2)); | ||
| expect(find.byType(ChatAssistantCard), findsNWidgets(2)); | ||
| expect(find.text('Suas conversas (2)'), findsOneWidget); | ||
| }), | ||
| ); | ||
|
|
||
| testWidgets( | ||
| 'should trigger refresh and fetch new data when pull to refresh is activated', | ||
| (tester) => mockNetworkImages(() async { | ||
| // arrange | ||
| when(() => mockRepository.listChannel()).thenAnswer( | ||
| (_) async => right(_chatChannelAvailableFixture), | ||
| ); | ||
| // act | ||
| await tester.pumpWidget( | ||
| MaterialApp( | ||
| home: ChatMainTalksPage(controller: controller), | ||
| ), | ||
| ); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| // Primeira chamada durante initialize | ||
| verify(() => mockRepository.listChannel()).called(1); | ||
|
|
||
| await tester.drag(find.byType(ListView), const Offset(0, 300)); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| // Assert | ||
| // Segunda chamada durante o refresh | ||
| verify(() => mockRepository.listChannel()).called(1); | ||
| }), | ||
| ); | ||
|
|
||
| testWidgets( | ||
| 'should navigate to chat when assistant card is tapped', | ||
| (tester) => mockNetworkImages(() async { | ||
| // arrange | ||
| when(() => mockRepository.listChannel()).thenAnswer( | ||
| (_) async => right(_chatChannelAvailableFixture), | ||
| ); | ||
|
|
||
| when(() => mockNavigator.popAndPushNamed(any(), | ||
| arguments: any(named: 'arguments'))) | ||
| .thenAnswer((_) => Future.value()); | ||
|
|
||
| await tester.pumpWidget( | ||
| MaterialApp( | ||
| home: ChatMainTalksPage(controller: controller), | ||
| ), | ||
| ); | ||
| await tester.pumpAndSettle(); | ||
| // act | ||
| await tester.tap(find.text('Assistente PenhaS')); | ||
| await tester.pumpAndSettle(); | ||
| // assert | ||
| verify( | ||
| () => mockNavigator.popAndPushNamed( | ||
| '/quiz?origin=chat', | ||
| arguments: any(named: 'arguments'), | ||
| ), | ||
| ).called(1); | ||
| }), | ||
| ); | ||
| }); | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Para melhorar a lógica, é melhor manter a criação do controllers no Bind (onde já estão) e aqui consumir a injeção, melhorando a organização e a manutenibilidade do código.