Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in the currency automation script #743

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Improvements in the currency automation script #743

merged 2 commits into from
Apr 24, 2024

Conversation

nithinputhenveettil
Copy link
Member

The current automation script lacks the ability to update using the following libraries :

https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/data/azcosmos
https://pkg.go.dev/github.com/IBM/sarama
https://pkg.go.dev/github.com/julienschmidt/httprouter

This PR Improves the automation script to facilitate updating all of these libraries.

Changes:

  • Fixed a minor typo in the httprouter URL.
  • Fixed issues with the proxy.golang API call when the package URL contains capital letters.

@nithinputhenveettil nithinputhenveettil added the tekton_ci Add this label to start running Tekton pipelines label Apr 24, 2024
@nithinputhenveettil nithinputhenveettil self-assigned this Apr 24, 2024
@nithinputhenveettil nithinputhenveettil requested a review from a team as a code owner April 24, 2024 05:41
sanojsubran
sanojsubran approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@sanojsubran sanojsubran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the quick response.

@nithinputhenveettil nithinputhenveettil merged commit 6a4946d into main Apr 24, 2024
3 checks passed
@nithinputhenveettil nithinputhenveettil deleted the currency-automation-script-improvement branch April 24, 2024 07:46
@nithinputhenveettil nithinputhenveettil mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanojsubran sanojsubran sanojsubran approved these changes

@Angith Angith Angith approved these changes

Assignees

@nithinputhenveettil nithinputhenveettil

Labels
tekton_ci Add this label to start running Tekton pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nithinputhenveettil @sanojsubran @Angith