Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): Updating manifests since now storage class is defined… #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Jcardoso-Instadeep
Copy link

This PR comes after the changes done in AIChor where the storage class is no longer defined during import but rather at experiment level, in the manifest

See: MR

… at the experiment level, instead of during cluster import
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

… at the experiment level, instead of during cluster import
@a-pichard
Copy link
Contributor

Could you add them but commented, the goal of these manifest is to start experiments with a minimal configuration

@Jcardoso-Instadeep
Copy link
Author

Fixed it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants