-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support latest Jumanji version #1134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @WiemKhlifi! Just a few questions, but it looks mostly good to me.
As a sanity check can you please do a few test runs to just check that the system performance is unaffected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Wiem, couple small things, mostly removing the git stuff from requirements.txt where possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WiemKhlifi. Some suggestions from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a marl-eval dependency suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕹️
Feat: Support latest Jumanji version
- chore:add git path to marll-eval - Merge branch develop into feat/update_juamnji - ci: increase time-out to 10 - chore: set the default aggregate_rewards to True - chore: cleaning based on review - Merge branch develop into feat/update_juamnji - Merge branch develop into feat/update_juamnji - ci: remove git path from requirements - fix: use cached action_spec - revert: add mpe to configs - chore: pin to latest jumanji now - Merge branch develop into feat/update_juamnji - feat: use multi-agent connector instead - chore: remove uneeded comments - Merge branch develop into feat/update_juamnji - chore: remove extra space - feat: fully support recent jumanji! - fix: fix connector shape bug - feat: add cached_prop decorator to all specs - feat: Remove Maconnector and use connector from main jumanji - feat: update jumanji version Co-authored-by: Ruan de Kock <[email protected]>
- chore:add git path to marll-eval - Merge branch develop into feat/update_juamnji - ci: increase time-out to 10 - chore: set the default aggregate_rewards to True - chore: cleaning based on review - Merge branch develop into feat/update_juamnji - Merge branch develop into feat/update_juamnji - ci: remove git path from requirements - fix: use cached action_spec - revert: add mpe to configs - chore: pin to latest jumanji now - Merge branch develop into feat/update_juamnji - feat: use multi-agent connector instead - chore: remove uneeded comments - Merge branch develop into feat/update_juamnji - chore: remove extra space - feat: fully support recent jumanji! - fix: fix connector shape bug - feat: add cached_prop decorator to all specs - feat: Remove Maconnector and use connector from main jumanji - feat: update jumanji version
What?
Upgrade to the latest Jumanji version of
1.0.1
instead of0.3.1
and pin to the original and latestJumanji
andMatrax
.How?
requirements.txt
to use original versions instead of a fork.Extra:
super().__init__(env)
( Theself.__getattr__(env,name)
in parent class can't get the attribute from env if it's defined with different name in the env wrapper class).For example: