Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to arbitrarily chain torso configs together #1099

Closed
wants to merge 5 commits into from

Conversation

EdanToledo
Copy link
Contributor

What?

Add ability to chain different torsos together based on configs.

Why?

Allows construction of complicated networks through configs alone.

How?

Add a new class of network and a constructer function called by hydra.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 1, 2024
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 1, 2024
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be cool to just have a network which is and this is the base of all networks in mava:

class Network(nn.Module)
    torso: CompositeNetwork
    head: nn.Module

    def __call__(x, ...):
        x = do some stuff to the input  # each different network would do different stuff e.g centralized/decentralized etc
        return head(torso(x))

But we can leave this for another PR

@sash-a
Copy link
Contributor

sash-a commented Nov 13, 2024

Thanks for this @EdanToledo we've decided to not add this for now because we don't really have mava setup to use it and instead create a PR using this to overhaul the whole network module and make it more flexible using this at the core.

We're making it an issue for now and will get to it after our next research push

@EdanToledo
Copy link
Contributor Author

😴

@sash-a sash-a deleted the feat/torso_chaining branch February 7, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants