fix[ui][backoffice]: remove ORCID from the author links box #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspirehep
|
||||||||||||||||||||||||||||
| Project |
inspirehep
|
| Branch Review |
#678-backoffice-remove-ORCID-from-the-links-box
|
| Run status |
|
| Run duration | 07m 28s |
| Commit |
|
| Committer | Lorenzo Vagliano |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
37
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
Lorenzovagliano
force-pushed
the
#678-backoffice-remove-ORCID-from-the-links-box
branch
2 times, most recently
from
61fb6ef to
c1602bb
Compare
PascalEgn
requested changes
Jan 17, 2025
ioannistsanaktsidis
requested changes
Jan 17, 2025
There was a problem hiding this comment.
@Lorenzovagliano we also have this method here https://github.com/inspirehep/inspirehep/blob/master/ui/src/backoffice/authors/components/AuthorMainInfo.tsx#L19 . Very similar to what you are doing. What we can do so as to normalize everything is to move these methods to the utils file here https://github.com/inspirehep/inspirehep/blob/master/ui/src/backoffice/utils/utils.tsx and reuse them everywhere. That way we can have consistency and more readability.
Lorenzovagliano
force-pushed
the
#678-backoffice-remove-ORCID-from-the-links-box
branch
3 times, most recently
from
13672b2 to
a43ac5f
Compare
Signed-off-by: Lorenzo Vagliano
Lorenzovagliano
force-pushed
the
#678-backoffice-remove-ORCID-from-the-links-box
branch
from
a43ac5f to
53674c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: cern-sis/issues-inspire#678