Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: inject data authors from literature link #3378

Merged
merged 1 commit into from
Jan 22, 2025
Merged

backend: inject data authors from literature link #3378

merged 1 commit into from
Jan 22, 2025

Conversation

PascalEgn
Copy link
Collaborator

@PascalEgn PascalEgn marked this pull request as draft January 14, 2025 14:33
@cypress Cypress
Copy link

cypress bot commented Jan 14, 2025 •
edited
Loading

inspirehep    Run #33635

Run Properties:  status check passed Passed #33635  •  git commit 36ec5d0c2b: backend & ui: inject data authors from literature link
Project inspirehep
Branch Review display-authors-for-data
Run status status check passed Passed #33635
Run duration 07m 13s
Commit git commit 36ec5d0c2b: backend & ui: inject data authors from literature link
Committer PascalEgn
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 37
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 67
View all changes introduced in this branch ↗︎

@PascalEgn PascalEgn force-pushed the display-authors-for-data branch 5 times, most recently from 7fd9644 to 330018b Compare January 20, 2025 13:48
@PascalEgn PascalEgn marked this pull request as ready for review January 20, 2025 13:50
@PascalEgn PascalEgn force-pushed the display-authors-for-data branch 4 times, most recently from 37ddbe6 to 5172224 Compare January 20, 2025 16:12
ioannistsanaktsidis
ioannistsanaktsidis approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@ioannistsanaktsidis ioannistsanaktsidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

drjova
drjova requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@drjova drjova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor improvements

backend/inspirehep/records/marshmallow/data/es.py Outdated Show resolved Hide resolved
backend/inspirehep/records/marshmallow/data/utils.py Outdated Show resolved Hide resolved
backend/inspirehep/records/marshmallow/data/utils.py Outdated Show resolved Hide resolved
@PascalEgn PascalEgn force-pushed the display-authors-for-data branch 2 times, most recently from 568fd2b to 60eec6b Compare January 21, 2025 14:12
@PascalEgn PascalEgn force-pushed the display-authors-for-data branch from 60eec6b to 2d24384 Compare January 21, 2025 15:58
@PascalEgn PascalEgn force-pushed the display-authors-for-data branch from 2d24384 to 098b064 Compare January 22, 2025 09:52
@PascalEgn PascalEgn force-pushed the display-authors-for-data branch from 098b064 to 36ec5d0 Compare January 22, 2025 10:16
@PascalEgn PascalEgn merged commit 93baed1 into inspirehep:master Jan 22, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgrc miguelgrc miguelgrc approved these changes

@ioannistsanaktsidis ioannistsanaktsidis ioannistsanaktsidis approved these changes

@drjova drjova drjova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PascalEgn @drjova @ioannistsanaktsidis @miguelgrc