data: add hepdata as acquisitionsource #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DonHaul
commented
Dec 20, 2024
DonHaul
commented
- ref: add 'inspirehep' as an acquisition source for data cern-sis/issues-inspire#630
DonHaul
force-pushed
the
add-heppdata-acquisitionsource
branch
from
664b5d3 to
32ed834
Compare
2 tasks
michamos
reviewed
Dec 20, 2024
| enum: | ||
| - submitter | ||
| - oai | ||
| - batchuploader | ||
| - hepcrawl | ||
| - beard | ||
| - hepdata |
There was a problem hiding this comment.
I don't think this should be hepdata. The acquisition_source is not the same thing as the source, it's meant to represent how we got it (i.e. the tool) rather than the source. So you'd need a name for the new harvesting component.
There was a problem hiding this comment.
I see, to be checked then what should be its name, maybe something like backofficeharvester
There was a problem hiding this comment.
let's call it inspirehep, wdyt?
DonHaul
force-pushed
the
add-heppdata-acquisitionsource
branch
from
32ed834 to
4a92b6b
Compare
DonHaul
force-pushed
the
add-heppdata-acquisitionsource
branch
from
4a92b6b to
6727c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.