Data MVP #467
Merged
Data MVP #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michamos
commented
Nov 21, 2024
michamos
commented
- Also makes normalization script compatible with recent Python
- Also fixes generation script to run on recent Node versions
michamos
commented
Nov 21, 2024
| @@ -88,6 +426,28 @@ properties: | |||
| minLength: 1 | |||
| title: Last record update | |||
| type: string | |||
| literature: | |||
There was a problem hiding this comment.
We will need to link from the data to the paper and back. I've done it like this, comments welcome.
| @@ -667,6 +667,28 @@ properties: | |||
| are all curated eventually, whereas non-core records are | |||
| not systematically curated. | |||
| type: boolean | |||
| data: | |||
There was a problem hiding this comment.
I've added this to link from the paper to the data, although it's not strictly needed for the MVP as the link is coming from the data record for HEPData. Should we drop it?
|
I can't fix tests as I can't run them locally because I can't install it due to needing to bump pytest, which blocks due to the |
michamos
commented
Nov 22, 2024
* Also makes normalization script compatible with recent Python * Also fixes generation script to run on recent Node versions
drjova
force-pushed
the
data-mvp
branch
3 times, most recently
from
b067d76 to
ab689ef
Compare
drjova
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.