Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal: use inspire-utils to parse names #2990

Closed
wants to merge 1 commit into from
Closed

hal: use inspire-utils to parse names #2990

wants to merge 1 commit into from

Conversation

jacquerie
Copy link
Contributor

@jacquerie jacquerie commented Nov 24, 2017 •
edited
Loading

Related Issue

Addresses #2273.

Checklist:

  • I have all the information that I need (if not, move to RFC and look for it).
  • I linked the related issue(s) in the corresponding commit logs.
  • I wrote good commit log messages.
  • My code follows the code style of this project.
  • I've added any new docs if API/utils methods were added.
  • I have updated the existing documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghost ghost assigned jacquerie Nov 24, 2017
@ghost ghost added the Status: WIP label Nov 24, 2017
@jacquerie jacquerie requested a review from chris-asl November 24, 2017 12:43
chris-asl
chris-asl approved these changes Nov 24, 2017
View reviewed changes
Copy link
Contributor

@chris-asl chris-asl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacquerie
hal: use inspire-utils to parse names
b9859e0 
Signed-off-by: Jacopo Notarstefano <[email protected]>
@jacquerie
Copy link
Contributor Author

Superseded by #2992.

@jacquerie jacquerie closed this Nov 25, 2017
@ghost ghost removed the Status: WIP label Nov 25, 2017
@jacquerie jacquerie deleted the fix-issue-2273 branch November 25, 2017 22:53
@jacquerie jacquerie mentioned this pull request Nov 25, 2017
Merged
8 tasks
@jacquerie jacquerie removed their assignment Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-asl chris-asl chris-asl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquerie @chris-asl