Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Commit

Permalink
Merge pull request #26 from inspirehep/add-post-workflow-ticket
Browse files Browse the repository at this point in the history
update workflow ticket view
  • Loading branch information
MJedr authored Dec 11, 2023
2 parents c28e170 + 3ff286f commit d703e1a
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 2 deletions.
18 changes: 17 additions & 1 deletion backoffice/workflows/api/views.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from django.shortcuts import get_object_or_404
from rest_framework import status, viewsets
from rest_framework.response import Response
from rest_framework.views import APIView

from backoffice.workflows.models import Workflow, WorkflowTicket

Expand Down Expand Up @@ -46,3 +45,20 @@ def retrieve(self, request, *args, **kwargs):
return Response(serializer.data)
except WorkflowTicket.DoesNotExist:
return Response({"error": "Workflow ticket not found."}, status=status.HTTP_404_NOT_FOUND)

def create(self, request, *args, **kwargs):
workflow_id = request.data.get("workflow_id")
ticket_type = request.data.get("ticket_type")

if not workflow_id or not ticket_type:
return Response(
{"error": "Both workflow_id and ticket_type are required."}, status=status.HTTP_400_BAD_REQUEST
)

try:
workflow = Workflow.objects.get(id=workflow_id)
workflow_ticket = WorkflowTicket.objects.create(workflow_id=workflow, ticket_type=ticket_type)
serializer = WorkflowTicketSerializer(workflow_ticket)
return Response(serializer.data, status=status.HTTP_201_CREATED)
except Exception as e:
return Response({"error": str(e)}, status=status.HTTP_500_INTERNAL_SERVER_ERROR)
17 changes: 16 additions & 1 deletion backoffice/workflows/tests/test_views.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import pytest
from django.apps import apps
from django.contrib.auth import get_user_model
from django.contrib.auth.models import Group
Expand Down Expand Up @@ -140,3 +139,19 @@ def test_get_ticket_happy_flow(self):

assert response.status_code == 200
assert response.data == WorkflowTicketSerializer(self.workflow_ticket).data

def test_create_missing_params(self):
self.api_client.force_authenticate(user=self.curator)
response = self.api_client.post(f"{TestWorkflowTicketViewSet.endpoint}/", format="json", data={})

assert response.status_code == 400
assert response.data == {"error": "Both workflow_id and ticket_type are required."}

def test_create_happy_flow(self):
self.api_client.force_authenticate(user=self.curator)

data = {"workflow_id": self.workflow.id, "ticket_type": "author_create_user"}
response = self.api_client.post(f"{TestWorkflowTicketViewSet.endpoint}/", format="json", data=data)

assert response.status_code == 201
assert response.data == WorkflowTicketSerializer(WorkflowTicket.objects.last()).data

0 comments on commit d703e1a

Please sign in to comment.