Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove universal fetch dep #2281

Merged
merged 8 commits into from
Dec 13, 2023
Merged

remove universal fetch dep #2281

merged 8 commits into from
Dec 13, 2023

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Dec 11, 2023

This PR fixes #.

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

New feature description

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • New modules (i.e. new .ts files) are listed in the exports field in package.json, if applicable.
  • New modules (i.e. new .ts files) are listed in the typedocOptions.entryPoints field in tsconfig.json, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

This PR bumps the version to .

Checklist

  • I inspected the changelog to determine if the release was major, minor or patch. I then used the command npm version <major|minor|patch> to update the package.json and package-lock.json (and locally create a tag).
  • The CHANGELOG has been updated to show version and release date - https://keepachangelog.com/en/1.0.0/.
  • @since X.Y.Z annotations have been added to new APIs.
  • The only commits in this PR are:
    • the CHANGELOG update.
    • the version update.
    • @since annotations.
  • I will make sure not to squash these commits, but rebase instead.
  • Once this PR is merged, I will push the tag created by npm version ... (e.g. git push origin vX.Y.Z).

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-client-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 9:13pm

@jeswr jeswr changed the title WIP: remove universal fetch dep remove universal fetch dep Dec 13, 2023
@jeswr jeswr merged commit 5f23fc9 into main Dec 13, 2023
29 of 30 checks passed
@jeswr jeswr deleted the wip/remove-univeral-fetch branch December 13, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants