Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'extra-libraries: m' #1453

Merged
merged 4 commits into from
May 26, 2022

Conversation

ramirez7
Copy link
Contributor

@ramirez7 ramirez7 commented Apr 24, 2022

I've been using this overlay in my project (compiling natively on NixOS + x-compiling to Windows) for over a year now.

hgeometry is the most notable Haskell library I know of that does this.

Fixes #1128

@angerman
Copy link
Collaborator

Shouldn't this be a system package mapped to null?

@ramirez7
Copy link
Contributor Author

I wasn't aware of that functionality - so I can just have m = null; at the top level in nixpkgs and that'll fix it? Also, is there a better place in haskell.nix to do this than where I've done it?

@hamishmack
Copy link
Collaborator

is there a better place in haskell.nix to do this than where I've done it?

Oh, yes. Try putting it in here https://github.com/input-output-hk/haskell.nix/blob/master/lib/system-nixpkgs-map.nix

@ramirez7
Copy link
Contributor Author

@hamishmack @angerman I've updated it to map m to null.

I also made this minimal reproduction for good measure: https://gitlab.com/ramirez7/bug-repros/-/tree/864172f0637cc58b82217525f62037c73d302a9d/haskell.nix/2022/05/libm-1128

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request May 25, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 25, 2022

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extra-libraries: m fails due to missing system dependency
3 participants