Modernize codebase and QA #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modernize codebase to support recent PHP versions and up-to-date Syde coding standards.
- Move logic from `utils.php` file to an internal `Functions` class (all-static, only for encapsulation and autoload).
- Modernize QA:
- Move out from Travis to GitHub actions.
- Rewrite tests, update PHPUnit version, tests now include the real WordPress functions instead of stubs.
- Added static analysis.
- Introduced `remove_all_object_hooks()`.
- Introduced `remove_static_method_hook()` to replace the now deprecated `remove_class_hook()` (which is converted to an alias).
- In `remove_closure_hook()` is now possible to use `"mixed"` as target parameter type when the closure param declare no type.
- License change from MIT to GPL due to usage of WordPress functions.
- README refresh.
[ci skip]
[ci skip]
Chrico
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix, Feature, docs update.
What is the current behavior? (You can also link to an open issue here)
Modern PHP versions are not fully supported, CI is not working (uses Travis), there's no static analysis, and the license is wrong
What is the new behavior (if this is a feature change)?
utils.phpfile to an internalFunctionsclass (all-static, only for encapsulation and autoload).remove_all_object_hooks().remove_static_method_hook()to replace the now deprecatedremove_class_hook()(which is converted to an alias).remove_closure_hook()is now possible to use"mixed"as the target parameter type when the closure param declares no type.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No (in the public API), Yes because remove "internal" functions.
Other information:
Suggested release if merged: 1.0.0.