Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign CPU MSM with taskflow #718

Merged
merged 28 commits into from
Jan 8, 2025
Merged

Redesign CPU MSM with taskflow #718

merged 28 commits into from
Jan 8, 2025

Conversation

mickeyasa
Copy link
Contributor

Algorithm accelerated to use better parallelism via taskflow library

@mickeyasa mickeyasa changed the title Using taskflow MSM using taskflow Jan 1, 2025
yshekel
yshekel approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@yshekel yshekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Only thing, I see no error handling, does it mean this code can never fail?

@yshekel yshekel requested a review from HadarIngonyama January 7, 2025 14:27
@yshekel yshekel changed the title MSM using taskflow redesign CPU MSM with taskflow Jan 7, 2025
@yshekel yshekel changed the title redesign CPU MSM with taskflow Redesign CPU MSM with taskflow Jan 7, 2025
danny-shterman
danny-shterman reviewed Jan 7, 2025
View reviewed changes
icicle/backend/cpu/src/curve/cpu_msm.hpp Outdated Show resolved Hide resolved
icicle/backend/cpu/src/curve/cpu_msm.hpp Outdated Show resolved Hide resolved
icicle/backend/cpu/src/curve/cpu_msm.hpp Outdated Show resolved Hide resolved
icicle/backend/cpu/src/curve/cpu_msm.hpp Outdated Show resolved Hide resolved
icicle/backend/cpu/src/curve/cpu_msm.hpp Outdated Show resolved Hide resolved
icicle/backend/cpu/src/curve/cpu_msm.hpp Outdated Show resolved Hide resolved
@mickeyasa mickeyasa merged commit 95c33e4 into main Jan 8, 2025
15 checks passed
@mickeyasa mickeyasa deleted the MSM--acceleration branch January 8, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HadarIngonyama HadarIngonyama HadarIngonyama left review comments

@yshekel yshekel yshekel approved these changes

@danny-shterman danny-shterman danny-shterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mickeyasa @yshekel @HadarIngonyama @danny-shterman