vec_ops: scalar * ext field #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Dec 31, 2024
LeonHibnik
reviewed
Jan 1, 2025
| let cfg = VecOpsConfig::default(); | ||
|
|
||
| test_utilities::test_set_main_device(); | ||
| mixed_mul_scalars(a_main, b, result_main, &cfg).unwrap(); |
There was a problem hiding this comment.
I'd like it to be a self contained test, compare mul with a naive addition loop
There was a problem hiding this comment.
shouldn't we also need to add mixed_add_scalars function to achieve that?
There was a problem hiding this comment.
I meant res = scalar*ext and a loop over res += ext scalar times
LeonHibnik
approved these changes
Jan 1, 2025
yshekel
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuda-backend-branch: scalar_mul_ext