[FEAT] Add Koalabear field support #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonam3e
requested review from
ChickenLover,
yshekel,
jeremyfelder,
emirsoyturk and
LeonHibnik
yshekel
reviewed
Dec 25, 2024
| // Please modify the code generation script instead. | ||
| // Path to the code generation script: scripts/gen_c_api.py | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
@ChickenLover @nonam3e do we even need those files (under api)? I suggest removing them. it's probably never used and no reason to use them.
There was a problem hiding this comment.
sorry, didn't noticed that current examples depend on these files. It's better to remove them in another pr
There was a problem hiding this comment.
@yshekel we need to discuss about it removing them, and in another PR ofc
yshekel
approved these changes
Dec 25, 2024
icicle/include/icicle/hash/poseidon_constants/constants/rounds_numbers_coalabear.txt
Outdated
Show resolved
Hide resolved
nonam3e
force-pushed
the
feat/koalabear
branch
from
0c90677 to
d74ee13
Compare
LeonHibnik
approved these changes
Dec 26, 2024
|
We should update the docs to include the new curve as well |
jeremyfelder
approved these changes
Dec 30, 2024
LeonHibnik
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds koalabear field into icicle