[FW][FIX] account_interests: Fix when having interval to run interest #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rov-adhoc @ica-adhoc this PR targets 18.0 and is the last of the forward-port chain. To merge the full chain, use More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@rov-adhoc @ica-adhoc ci/runbot-smarted failed on this forward-port PR |
rov-adhoc
force-pushed
the
18.0-17.0-T-47626-rov-YLPI-fw
branch
from
8a673d8 to
38dae95
Compare
|
@rov-adhoc @ica-adhoc this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @roboadhoc) |
|
@roboadhoc r+ |
1 similar comment
|
@roboadhoc r+ |
|
@rov-adhoc you may want to rebuild or fix this PR as it has failed CI. |
|
I'm sorry, @rov-adhoc: this PR is already reviewed, reviewing it again is useless. |
|
@roboadhoc r+ |
|
@rov-adhoc you may want to rebuild or fix this PR as it has failed CI. |
|
I'm sorry, @rov-adhoc: this PR is already reviewed, reviewing it again is useless. |
rov-adhoc
force-pushed
the
18.0-17.0-T-47626-rov-YLPI-fw
branch
2 times, most recently
from
a29b184 to
e4da670
Compare
|
@roboadhoc r+ |
1 similar comment
|
@roboadhoc r+ |
|
@rov-adhoc you may want to rebuild or fix this PR as it has failed CI. |
|
I'm sorry, @rov-adhoc: this PR is already reviewed, reviewing it again is useless. |
rov-adhoc
force-pushed
the
18.0-17.0-T-47626-rov-YLPI-fw
branch
from
a11540f to
f11b2d5
Compare
|
@roboadhoc r+ |
|
@rov-adhoc @ica-adhoc linked pull request(s) ingadhoc/account-financial-tools#654 not ready. Linked PRs are not staged until all of them are ready. |
|
@roboadhoc r+ |
|
I'm sorry, @rov-adhoc: this PR is already reviewed, reviewing it again is useless. |
|
@roboadhoc r+ |
1 similar comment
|
@roboadhoc r+ |
|
I'm sorry, @rov-adhoc: this PR is already reviewed, reviewing it again is useless. |
1 similar comment
|
I'm sorry, @rov-adhoc: this PR is already reviewed, reviewing it again is useless. |
rov-adhoc
force-pushed
the
18.0-17.0-T-47626-rov-YLPI-fw
branch
from
f11b2d5 to
9e159c0
Compare
|
@roboadhoc r+ |
X-original-commit: 04cdd73
rov-adhoc
force-pushed
the
18.0-17.0-T-47626-rov-YLPI-fw
branch
from
9e159c0 to
d3cd70a
Compare
|
@roboadhoc r+ |
roboadhoc
pushed a commit
to ingadhoc/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes #654 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#654 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#654 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/odoo-academic
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#189 X-original-commit: 04cdd73 Related: ingadhoc/account-financial-tools#654 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/odoo-academic
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#189 X-original-commit: 04cdd73 Related: ingadhoc/account-financial-tools#654 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/odoo-academic
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#189 X-original-commit: 04cdd73 Related: ingadhoc/account-financial-tools#654 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#654 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
roboadhoc
pushed a commit
that referenced
this pull request
Jan 30, 2025
closes #189 closes #193 X-original-commit: 04cdd73 Related: ingadhoc/account-financial-tools#654 Related: ingadhoc/account-financial-tools#659 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: Camila Vives <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
roboadhoc
pushed a commit
to ingadhoc/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes #654 closes #659 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Related: ingadhoc/odoo-academic#193 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: Camila Vives <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#654 closes ingadhoc#659 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Related: ingadhoc/odoo-academic#193 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: Camila Vives <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#654 closes ingadhoc#659 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Related: ingadhoc/odoo-academic#193 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: Camila Vives <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
rov-adhoc
added a commit
to adhoc-dev/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes ingadhoc#654 closes ingadhoc#659 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Related: ingadhoc/odoo-academic#193 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: Camila Vives <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
roboadhoc
pushed a commit
to ingadhoc/account-financial-tools
that referenced
this pull request
Jan 30, 2025
closes #654 closes #659 closes #663 X-original-commit: d7817f6 Related: ingadhoc/odoo-academic#189 Related: ingadhoc/odoo-academic#193 Signed-off-by: Ignacio Cainelli <[email protected]> Signed-off-by: Camila Vives <[email protected]> Signed-off-by: rov-adhoc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se realiza el arreglo de cuando se tiene un intervalo sobre el cual calcular.
Ese intervalo afecta a la deuda de periodos anteriores.
Por ejemplo si se tiene un interes mensual de 0,0068 diario y quiere que se repita cada 5 dias. Entonces a la hora de calcular el interes del perior anterio deberia ser 0,0068 int/dias * 5 dias * deuda
por otro lado, se quita el -1 ya que si se esta incluyenda la fecha de vencimiento entonces lo que ocurria es los siguiente
factura que vence el 15/10 y la corrida es del 16/10
entraba dado ('date_maturity', '>=', from_date) y esta resta (to_date - move.invoice_date_due).days) claramente daba 1 y al restarle luego 1 quedaba en 0 y nunca se cobra ese interes por ese dia de vencimiento
Forward-Port-Of: #186