[FIX] l10n_latam_check_ux: Fix internal transfer third party checks #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
3 times, most recently
from
ba9467c to
60c6f56
Compare
zaoral
reviewed
Jan 28, 2025
l10n_latam_check_ux/wizards/l10n_latam_payment_mass_transfer.py
Outdated
Show resolved
Hide resolved
l10n_latam_check_ux/wizards/l10n_latam_payment_mass_transfer.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| def _create_payments(self): | ||
| outbound_payment = super(L10nLatamPaymentMassTransfer,self.with_context( |
There was a problem hiding this comment.
add docstring to the method
| super(AccountPayment, rec.with_context( | ||
| default_l10n_latam_move_check_ids=rec.l10n_latam_move_check_ids, | ||
| ))._create_paired_internal_transfer_payment() | ||
| super(AccountPayment, self - third_party_checks)._create_paired_internal_transfer_payment() |
There was a problem hiding this comment.
this super should be inside or after the if of 31 line?
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
2 times, most recently
from
254d16d to
9754d16
Compare
rov-adhoc
changed the title
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
6 times, most recently
from
efb542e to
52229cd
Compare
This commit implements the necessary corrections to ensure that the deposit of third-party checks, through the wizard, behaves the same way as an internal transfer. This ensures consistency in the process and prevents validation discrepancies.
rov-adhoc
force-pushed
the
18.0-h-86054-rov
branch
from
52229cd to
26e4e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the necessary corrections to ensure
that the deposit of third-party checks, through the wizard,
behaves the same way as an internal transfer.
This ensures consistency in the process and prevents validation discrepancies.