Allow customized subnet list for nmap #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core purpose for this change is to allow Bjorn to function in large networks; 10.0.0.0/8 subnets have millions of available addresses. This is a known limitation of nmap; nothing is well-suited to poll this many hosts. This commit adds two new config items, boolean 'use_custom_subnets' and string[] 'custom_subnet_list'. By default, 'use_custom_subnets' is False which matches the current behavior of using the IP Interface subnet. If 'use_custom_subnets' is True, then the subnets in 'custom_subnet_list' are passed to nmap instead.
|
Please switch target branch to |
|
Yes please switch target branch to dev. |
|
Branch changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core purpose for this change is to allow Bjorn to function in large networks; 10.0.0.0/8 subnets have millions of available addresses. This is a known limitation of nmap; nothing is well-suited to poll this many hosts.
This commit adds two new config items, boolean 'use_custom_subnets' and string[] 'custom_subnet_list'. By default, 'use_custom_subnets' is False which matches the current behavior of using the IP Interface subnet. If 'use_custom_subnets' is True, then the subnets in 'custom_subnet_list' are passed to nmap instead.