Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor Argo to Swift.Decodable #1

Open
wants to merge 70 commits into
base: master
Choose a base branch
from

Conversation

jantimar
Copy link

@jantimar jantimar commented Mar 3, 2020

No description provided.

@jantimar jantimar force-pushed the feature/remove-argo branch 5 times, most recently from 888aa1f to f63d06f Compare March 10, 2020 16:06
let exportDateEnvelope = ExportDataEnvelope
.decodeJSONDictionary(json)
.value!
let exportDateEnvelope = try! ExportDataEnvelope
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throws -> test func

@@ -316,7 +316,7 @@ public struct Service: ServiceType {

public func fetchProjectStats(projectId: Int) ->
SignalProducer<ProjectStatsEnvelope, ErrorEnvelope> {
return request(.projectStats(projectId: projectId))
return request(route: .projectStats(projectId: projectId))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove import Argo

@jantimar jantimar force-pushed the feature/remove-argo branch 2 times, most recently from 476283a to 2221c1f Compare March 12, 2020 15:52
@jantimar jantimar force-pushed the feature/remove-argo branch 2 times, most recently from 941f60c to 4e057aa Compare March 13, 2020 08:31
@jantimar jantimar force-pushed the feature/remove-argo branch from 4e057aa to fb87e84 Compare March 13, 2020 11:02
@jantimar jantimar force-pushed the feature/remove-argo branch from 723a5f4 to cef048a Compare March 24, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant