FIX: avoid bool for function name for C23 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C23 now regards `bool` as keyword, so avoid using `bool` for function name. Closes indexdata#133 .
MikeTaylor
reviewed
Jan 14, 2025
| @@ -83,7 +83,7 @@ static void pr_term(const char **cpp, int stop_at_space, | |||
| *cpp = cp; | |||
| } | |||
|
|
|||
| static int node(struct cql_node *cn, | |||
There was a problem hiding this comment.
Why have you renamed this function as well as bool?
There was a problem hiding this comment.
Because if bool is renamed to node_bool (I think this name is not-bad choice), I think the original node function should be renamed similarly.
(New function have node_ prefix, so leaving original node function name is too confusing in my opinion.)
If you have better idea how to rename bool function, I can let you do so.
MikeTaylor
approved these changes
Jan 14, 2025
| @@ -83,7 +83,7 @@ static void pr_term(const char **cpp, int stop_at_space, | |||
| *cpp = cp; | |||
| } | |||
|
|
|||
| static int node(struct cql_node *cn, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C23 now regards
boolas keyword, so avoid usingboolfor function name.Closes #133 .