Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single quote and percent character in PGCRYPTO_KEY #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khattori
Copy link

Fixes #319

@coveralls
Copy link

coveralls commented Jan 27, 2021

Pull Request Test Coverage Report for Build 1292

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1288: 0.0%
Covered Lines: 149
Relevant Lines: 149

💛 - Coveralls

@peterfarrell
Copy link
Collaborator

@khattori Thanks for the PR. I'm slightly concerned about all the hoop jumping we are going through to get things properly formatted between ' and % etc.

I am now convinced we should be using Postgres Dollar Quoting and let the DB handle any issues with the string constants:

https://www.postgresqltutorial.com/dollar-quoted-string-constants/

Let's use $pgcrypto$ as our tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single quote in PGCRYPTO_KEY string causes syntax error
3 participants