Indicateur calcule #3594
Merged
Indicateur calcule #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnoux
reviewed
Mar 5, 2025
There was a problem hiding this comment.
Bien joué, gros taf 👏
Par contre j'ai pas mal de questions et commentaires. On en discute IRL quand tu peux.
NB au vu de la taille de la PR, il me semble qu'elle aurait pu être divisée en 2 PRs bien distinctes :
- le seed des indicateurs via spreadsheet
- le calcul des indicateurs
En terme de review en tout cas ça m'aurait simplifié la tâche 😅
…r d'une valeur d'indicateur, import de la définition des indicateurs depuis un spreadsheet
dthib
force-pushed
the
indicateur-calcule
branch
from
893ac40 to
7ecf723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passe en même temps les indicateurs dans le spreadsheet