Tet 1501/etapes fa #3477
Merged
Tet 1501/etapes fa #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cparthur
force-pushed
the
TET-1501/etapes-FA
branch
from
5683a4f to
8a116d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout de l'onglet Étapes à la fiche action
Ticket notion
Problème d'animation sur le drag and drop avec l'asynchrone.
(voir commentaires dans
Etapes.tsx)J'ai dû utiliser un state local pour manipuler les étapes.
Pour cela, j'ai créé un context afin de les manipuler en un seul endroit et ne pas devoir passer toutes les fonctions d'update au composants enfants.
Dans tous les cas il fallait faire de l'optimistic update afin d'avoir une expérience utilisateur fluide.
@elisfainstein, j'ai corrigé des erreurs en console provenant de la PR sur les états vides :
clip-rule, il faut les mettre en camel caseclipRule(corrigé)