Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retranscription du PAI dans le backend #3350

Closed
wants to merge 22 commits into from
Closed

Retranscription du PAI dans le backend #3350

wants to merge 22 commits into from

Conversation

amandinejacquelin
Copy link
Contributor

No description provided.

farnoux
farnoux reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@farnoux farnoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un peu surpris de voir autant de code non utilisé (cf les quelques commentaires) et non lié au PAI.

Je suis assez mal à l'aise d'ajouter du code "mort" au repo. Ici c'est une quantité qui parait en plus non négligeable.

C'est quoi la logique derrière ?

backend/src/auth/services/auth.service.ts
* @param collectiviteId identifiant de la collectivité
* @param doNotThrow vrai pour ne pas générer une exception
*/
async verifieAccesRestreintCollectivite(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne trouve aucun usage de cette méthode ailleurs dans la PR. Normal ?

backend/src/auth/services/auth.service.ts
* @param tokenInfo token de l'utilisateur
* @return les informations crm de l'utilisateur
*/
async getUserCrmInfo(tokenInfo: SupabaseJwtPayload): Promise<userCrm | null> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem ici je ne trouve aucun usage de cette méthode ?

backend/src/collectivites/models/collectivite-test.table.ts
import { integer, pgTable, serial, varchar } from 'drizzle-orm/pg-core';
import { collectiviteTable } from './collectivite.table';

export const collectiviteTestTable = pgTable('collectivite_test', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem. je ne vois pas l'usage de cette table ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnoux farnoux farnoux left review comments

@dthib dthib Awaiting requested review from dthib

@elisfainstein elisfainstein Awaiting requested review from elisfainstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amandinejacquelin @farnoux