N'appelle plus le business si la configuration est vide, permet de fa…

…ire passer les tests sans le business.

data_layer/postgres/test/08-notation_service.sql

@@ -0,0 +1,23 @@
+create function
+    test.enable_evaluation_api()
+    returns void
+as
+$$
+insert into evaluation.service_configuration
+values ('http://business:8888/dl_evaluation/', 'http://business:8888/dl_personnalisation/');
+$$ language sql;
+comment on function test.enable_evaluation_api is
+    'Ajoute la configuration pour se connecter au business depuis Docker.';
+
+create function
+    test.disable_evaluation_api()
+    returns void
+as
+$$
+truncate evaluation.service_configuration;
+$$ language sql;
+comment on function test.disable_evaluation_api is
+    'Supprime les configurations pour se connecter au business ce qui désactive les appels.';
+
+
+select test.enable_evaluation_api();

data_layer/sqitch/deploy/evaluation/score_service.sql

@@ -10,10 +10,6 @@ create table evaluation.service_configuration
     created_at                timestamptz default now() not null
 );
 
-insert into evaluation.service_configuration
-values ('http://business:8888/dl_evaluation/', 'http://business:8888/dl_personnalisation/');
-
-
 -- todo move in personnalisation service
 create view evaluation.service_reponses
 as
@@ -77,9 +73,15 @@ with payload as (select ci.id as collectivite_id,
                                 (select reponses from evaluation.service_reponses sr where sr.collectivite_id = ci.id)
                             ) as payload
                  from collectivite_identite ci
-                 where ci.id = evaluate_regles.collectivite_id)
+                 where ci.id = evaluate_regles.collectivite_id),
+     configuration as (select *
+                       from evaluation.service_configuration
+                       order by created_at desc
+                       limit 1)
+
 select post.*
-from payload
+from configuration -- si il n'y a aucune configuration on ne fait pas d'appel
+         join payload on true
          left join lateral (select *
                             from http_post(
                                     (select personnalisation_endpoint
@@ -93,7 +95,8 @@ from payload
 $$
     language sql
     security definer
-    set search_path = public, extensions; -- permet d'utiliser l'extension http depuis un trigger
+    set search_path = public, extensions;
+-- permet d'utiliser l'extension http depuis un trigger
 
 -- select * from evaluation.evaluate_regles(1);
 
@@ -209,16 +212,18 @@ with payload as (select s.collectivite_id,
                  from evaluation.service_referentiel as r
                           left join evaluation.service_statuts s on s.referentiel = r.referentiel
                  where r.referentiel = evaluate_statuts.referentiel
-                   and s.collectivite_id = evaluate_statuts.collectivite_id)
+                   and s.collectivite_id = evaluate_statuts.collectivite_id),
+     configuration as (select *
+                       from evaluation.service_configuration
+                       order by created_at desc
+                       limit 1)
 
 select post.*
-from payload
+from configuration -- si il n'y a aucune configuration on ne fait pas d'appel
+         join payload on true
          left join lateral (select *
                             from http_post(
-                                    (select evaluation_endpoint
-                                     from evaluation.service_configuration
-                                     order by created_at desc
-                                     limit 1),
+                                    configuration.evaluation_endpoint,
                                     to_jsonb(payload.*)::varchar,
                                     'application/json'::varchar
                                 )

data_layer/tests/evaluation/action_statut_update_event.sql

@@ -1,6 +1,9 @@
 begin;
 select plan(8);
 
+-- prevent calls to the business service
+select test.disable_evaluation_api();
+
 -- prepare
 truncate client_scores;
 truncate action_statut;

data_layer/tests/evaluation/reponse_historique.sql

@@ -1,5 +1,6 @@
 begin;
 select plan(27);
+select test.disable_evaluation_api();
 
 -- Enlève les triggers pour tester le debounce - sinon les modified_at sont toujours égaux à now().
 drop trigger set_modified_at_before_reponse_proportion_update on reponse_proportion;

data_layer/tests/evaluation/thematique_completude.sql

@@ -1,5 +1,6 @@
 begin;
 select plan(13);
+select test.disable_evaluation_api();
 
 select has_view('question_thematique_completude');
 select has_column('question_thematique_completude', 'collectivite_id');

data_layer/tests/labellisation/fichier_preuve.sql

@@ -1,6 +1,7 @@
 begin;
 
 select plan(4);
+select test.disable_evaluation_api();
 
 truncate storage.objects cascade;
 truncate labellisation.bibliotheque_fichier cascade;

data_layer/tests/labellisation/labellisation.sql

@@ -1,6 +1,9 @@
 begin;
 select plan(35);
 
+-- prevent calls to the business service
+select test.disable_evaluation_api();
+
 select has_function('labellisation', 'referentiel_score'::name);
 select has_function('labellisation', 'etoiles'::name);
 select has_function('labellisation_parcours');

data_layer/tests/referentiel/action_statut_historique.sql

@@ -1,5 +1,6 @@
 begin;
 select plan(9);
+select test.disable_evaluation_api();
 
 -- Enlève le trigger pour tester le debounce - sinon les modified_at sont toujours égaux à now().
 drop trigger if exists set_modified_at_action_statut_update on action_statut;

data_layer/tests/referentiel/filterable_referentiel_view.sql

@@ -1,6 +1,7 @@
 begin;
 select plan(7);
 select has_view('action_statuts');
+select test.disable_evaluation_api();
 
 truncate action_statut;
 truncate client_scores;

data_layer/tests/utils/move_action_data.sql

@@ -1,6 +1,6 @@
 begin;
 select plan(6);
-
+select test.disable_evaluation_api();
 select test.identify_as('yolo@dodo.com');
 
 truncate table action_statut;