Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctifs assistants avant mise en prod #1252

Merged
merged 16 commits into from
Jan 27, 2025
Merged

Conversation

fabienheureux
Copy link
Member

@fabienheureux fabienheureux commented Jan 22, 2025

Description succincte du problème résolu

Type de changement :

  • Bug fix
  • Nouvelle fonctionnalité
  • Mise à jour de données / DAG
  • Les changements nécessitent une mise à jour de documentation
  • Refactoring de code (explication à retrouver dans la description)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

@fabienheureux fabienheureux force-pushed the assistant-feedbacks-22-1 branch 6 times, most recently from 847f692 to bc561f8 Compare January 23, 2025 08:49
servers.conf.erb Outdated Show resolved Hide resolved
@fabienheureux fabienheureux force-pushed the assistant-feedbacks-22-1 branch 3 times, most recently from 59f9175 to 01ae697 Compare January 23, 2025 15:30
@fabienheureux fabienheureux force-pushed the assistant-feedbacks-22-1 branch from 4c64361 to cfa35e6 Compare January 23, 2025 17:27
@fabienheureux fabienheureux force-pushed the assistant-feedbacks-22-1 branch from ad9a5a3 to 81484f2 Compare January 23, 2025 17:56
@fabienheureux fabienheureux marked this pull request as ready for review January 27, 2025 09:40
@fabienheureux fabienheureux requested a review from a team as a code owner January 27, 2025 09:40
@fabienheureux fabienheureux requested review from kolok and maxcorbeau and removed request for a team January 27, 2025 09:40
@fabienheureux fabienheureux changed the title Assistant feedbacks 22 1 Correctifs assistants avant mise en prod Jan 27, 2025
Procfile Outdated Show resolved Hide resolved
bin/post_compile Outdated Show resolved Hide resolved
bin/start Show resolved Hide resolved
bin/start Show resolved Hide resolved
qfdmd/views.py Show resolved Hide resolved
servers.conf.erb Show resolved Hide resolved
static/to_compile/js/search_solution_form_controller.ts Outdated Show resolved Hide resolved
…Sur-mobile-il-manque-la-barre-du-bas-avec-partager-int-grer-et-contacter-1826523d57d7806c93b1ca8ec3768d0d?pvs=4
…Changer-l-ordre-des-onglets-dans-la-fiche-produit-17d6523d57d780a781fed8125a883eab?pvs=4
…Si-pas-de-lien-produit-ne-pas-afficher-l-onglet-en-savoir-plus-1826523d57d780a6a96ee594c48c377a?pvs=4
@fabienheureux fabienheureux enabled auto-merge (squash) January 27, 2025 14:52
@fabienheureux fabienheureux merged commit eb67583 into main Jan 27, 2025
11 checks passed
@fabienheureux fabienheureux deleted the assistant-feedbacks-22-1 branch January 27, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants