Améliorations posthog #1229
Open
Améliorations posthog #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- meilleure gestion du mode iframe - correctif sur le script qui ne redirige pas sur la bonne route
fabienheureux
requested review from
kolok and
maxcorbeau
and removed request for
a team
maxcorbeau
approved these changes
Jan 20, 2025
| @@ -91,7 +91,7 @@ export default class extends Controller<HTMLElement> { | |||
| this.personProperties.iframe = true | |||
| } | |||
|
|
|||
| if (document.referrer) { | |||
| if (document.referrer && !document.referrer.includes(document.location.origin)) { | |||
There was a problem hiding this comment.
Peut être que le code parait évident pour celui qui l'écrit: mais vu qu'on a une single codebase avec plusieurs stacks (javascript, python) et différentes expertises (front, data engineering etc...) je rajouterais 1 ligne avec explication:
"Inclure l'analytics que si l'utilisateur provient d'un autre site parce que ___"
There was a problem hiding this comment.
Est-ce que quelque chose comme ça te parlerait ?
Suggested change
| if (document.referrer && !document.referrer.includes(document.location.origin)) { | |
| const referrerIsExternal = document.referrer && !document.referrer.includes(document.location.origin) | |
| if (referrerIsExternal) { |
Je peux ajouter un commentaire, mais j'aime bien un nommage propre, c'est mieux maintenu 😇
There was a problem hiding this comment.
oui c'est mieux mais ce que le code n'explique pas c'est le pourquoi: pourquoi on fait l'inclusion uniquement dans le cas d'un referrer externe?
kolok
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
https://www.notion.so/accelerateur-transition-ecologique-ademe/AST-1-Mise-en-place-du-tracking-nouvelle-archi-assistant-sur-Posthog-et-Matomo-1266523d57d780399115d465f94dfa88?pvs=4
Type de changement :
Auto-review
Les trucs à faire avant de demander une review :
.env.template