Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conserver le mode iframe durant la navigation #1215

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Conserver le mode iframe durant la navigation #1215

merged 8 commits into from
Jan 21, 2025

Conversation

fabienheureux
Copy link
Member

@fabienheureux fabienheureux commented Jan 14, 2025 •
edited
Loading

Description succincte du problème résolu

cf https://www.notion.so/accelerateur-transition-ecologique-ademe/Si-iFram-et-que-je-clique-dans-une-fiche-produit-sur-le-logo-a-revient-la-page-d-accueil-mais-av-17b6523d57d7800ea4dbe206b5af86b5?pvs=4

Mise en place des sessions django pour les visiteurs anonymes

  • une session est créée lors de la première visite pour stocker la valeur iframe
  • on définit l'expiration de la session lorsque l'utilisateur ferme le navigateur
  • on déclencher diverses variations dans les templates basées sur cette session

En bonus

Affichage d'infos de debug dans les templates

image

Type de changement :

  • Bug fix
  • Nouvelle fonctionnalité
  • Mise à jour de données / DAG
  • Les changements nécessitent une mise à jour de documentation
  • Refactoring de code (explication à retrouver dans la description)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

@fabienheureux fabienheureux force-pushed the keep-querystring-in-assistant-links branch from b11630f to 3d1219c Compare January 15, 2025 10:04
@fabienheureux fabienheureux changed the title Ajout de la querystring aux liens Conserver le mode iframe durant la navigation Jan 15, 2025
@fabienheureux fabienheureux marked this pull request as ready for review January 15, 2025 10:38
@fabienheureux fabienheureux requested a review from a team as a code owner January 15, 2025 10:38
@fabienheureux fabienheureux requested review from kolok and maxcorbeau and removed request for a team January 15, 2025 10:38
@fabienheureux fabienheureux enabled auto-merge (squash) January 15, 2025 10:44
kolok
kolok reviewed Jan 15, 2025
View reviewed changes
templates/qfdmd/base.html Show resolved Hide resolved
core/context_processors.py Show resolved Hide resolved
@fabienheureux fabienheureux merged commit c23b8ca into main Jan 21, 2025
11 checks passed
@fabienheureux fabienheureux deleted the keep-querystring-in-assistant-links branch January 21, 2025 14:03
kolok added a commit that referenced this pull request Jan 21, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
90610a7 
This reverts commit c23b8ca.
kolok added a commit that referenced this pull request Jan 21, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
56f443a 
This reverts commit c23b8ca.
kolok added a commit that referenced this pull request Jan 22, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
86bd657 
This reverts commit c23b8ca.
kolok added a commit that referenced this pull request Jan 22, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
46c3e19 
This reverts commit c23b8ca.
kolok added a commit that referenced this pull request Jan 22, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
cccf344 
This reverts commit c23b8ca.
kolok added a commit that referenced this pull request Jan 22, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
f058db4 
This reverts commit c23b8ca.
kolok added a commit that referenced this pull request Jan 23, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
aae5bc8 
This reverts commit c23b8ca.
fabienheureux pushed a commit that referenced this pull request Jan 23, 2025
@kolok @fabienheureux
Revert "Conserver le mode iframe durant la navigation (#1215)"
d631bc4 
This reverts commit c23b8ca.
kolok added a commit that referenced this pull request Jan 23, 2025
@kolok
Revert "Conserver le mode iframe durant la navigation (#1215)"
dad18f5 
This reverts commit c23b8ca.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolok kolok kolok approved these changes

@maxcorbeau maxcorbeau Awaiting requested review from maxcorbeau maxcorbeau is a code owner automatically assigned from incubateur-ademe/lvao-admin

Assignees

@kolok kolok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabienheureux @kolok