Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout du formulaire de contact dans l'assistant #1190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fabienheureux
Copy link
Member

@fabienheureux fabienheureux commented Jan 8, 2025

Description succincte du problème résolu

https://www.notion.so/accelerateur-transition-ecologique-ademe/Envoi-d-un-message-il-manque-le-formulaire-de-contact-1536523d57d780d9875fd5b2c900825d?pvs=4

Ajout d'un formulaire de contact au clic sur la modal

⚠️ pour le moment on ne fait rien à la soumission, j'attends d'avoir accès au projet Airtable pour vérifier où envoyer les données

Type de changement :

  • Bug fix
  • Nouvelle fonctionnalité
  • Mise à jour de données / DAG
  • Les changements nécessitent une mise à jour de documentation
  • Refactoring de code (explication à retrouver dans la description)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

@fabienheureux fabienheureux marked this pull request as ready for review January 9, 2025 13:40
@fabienheureux fabienheureux requested a review from a team as a code owner January 9, 2025 13:40
@fabienheureux fabienheureux requested review from kolok and maxcorbeau and removed request for a team January 9, 2025 13:40
Copy link
Contributor

@maxcorbeau maxcorbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tout me parait bien.

Copy link
Contributor

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai fait quelques remarques :)

qfdmd/views.py Outdated
success_url = reverse_lazy("qfdmd:nous-contacter-confirmation")

def form_valid(self, form):
logger.error(f"{form=}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je suppose que c'est un relicat :)
Sinon on va avoir beaucoup de Sentry

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui c'est en attendant de brancher l'API :D (je comptais pas merger ça mais bien vu)

qfdmd/urls.py Show resolved Hide resolved
templates/forms/contact.html Show resolved Hide resolved
templates/forms/contact.html Show resolved Hide resolved
@fabienheureux fabienheureux force-pushed the contact-form-assistant branch 4 times, most recently from edde69e to a8ef448 Compare January 15, 2025 11:52
@fabienheureux fabienheureux force-pushed the contact-form-assistant branch from a8ef448 to f6d6012 Compare January 20, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants