-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajout du formulaire de contact dans l'assistant #1190
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tout me parait bien.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai fait quelques remarques :)
qfdmd/views.py
Outdated
success_url = reverse_lazy("qfdmd:nous-contacter-confirmation") | ||
|
||
def form_valid(self, form): | ||
logger.error(f"{form=}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je suppose que c'est un relicat :)
Sinon on va avoir beaucoup de Sentry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oui c'est en attendant de brancher l'API :D (je comptais pas merger ça mais bien vu)
edde69e
to
a8ef448
Compare
a8ef448
to
f6d6012
Compare
Description succincte du problème résolu
https://www.notion.so/accelerateur-transition-ecologique-ademe/Envoi-d-un-message-il-manque-le-formulaire-de-contact-1536523d57d780d9875fd5b2c900825d?pvs=4
Ajout d'un formulaire de contact au clic sur la modal
Type de changement :
Auto-review
Les trucs à faire avant de demander une review :
.env.template
Comment tester
En local / staging :