Correction des transformations quand la colonne origin et destination…

… est la même (#1126)
incubateur-ademe · Dec 11, 2024 · 22b832b · 22b832b
1 parent dbdb5e8
commit 22b832b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/dags/sources/tasks/business_logic/source_data_normalize.py b/dags/sources/tasks/business_logic/source_data_normalize.py
@@ -57,7 +57,8 @@ def source_data_normalize(
         df[transformation["destination"]] = df[transformation["origin"]].apply(
             TRANSFORMATION_MAPPING[function_name]
         )
-        df.drop(columns=[transformation["origin"]], inplace=True)
+        if transformation["destination"] != transformation["origin"]:
+            df.drop(columns=[transformation["origin"]], inplace=True)
 
     # DEBUT Traitement des identifiants
 

diff --git a/dags_unit_tests/sources/tasks/business_logic/test_source_data_normalize.py b/dags_unit_tests/sources/tasks/business_logic/test_source_data_normalize.py
@@ -263,7 +263,7 @@ class TestSourceDataNormalize:
     - [ ] test Suppresion des colonnes non voulues
     - [ ] test ignore_duplicates
     - [ ] test produitsdechets_acceptes vide ou None
-    - [ ] test transformation from column_transformations is called
+    - [x] test transformation from column_transformations is called
     """
 
     @pytest.fixture
@@ -523,7 +523,12 @@ def test_column_transformations_is_called(self, source_data_normalize_kwargs):
                 "origin": "nom origin",
                 "transformation": "test_fct",
                 "destination": "nom destination",
-            }
+            },
+            {
+                "origin": "nom",
+                "transformation": "test_fct",
+                "destination": "nom",
+            },
         ]
         source_data_normalize_kwargs["df_acteur_from_source"] = pd.DataFrame(
             {
@@ -532,7 +537,8 @@ def test_column_transformations_is_called(self, source_data_normalize_kwargs):
                 "source_id": ["source_id1"],
                 "acteur_type_id": ["decheterie"],
                 "produitsdechets_acceptes": ["Plastic Box"],
-                "nom origin": ["nom"],
+                "nom origin": ["nom origin 1"],
+                "nom": ["nom"],
             }
         )
 
@@ -541,6 +547,9 @@ def test_column_transformations_is_called(self, source_data_normalize_kwargs):
         assert "nom destination" in df.columns
         assert df["nom destination"].iloc[0] == "success"
 
+        assert "nom" in df.columns
+        assert df["nom"].iloc[0] == "success"
+
 
 class TestDfNormalizePharmacie:
     """