Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add fields on the organisation and poll forms #837

Merged
merged 36 commits into from
Feb 11, 2025
Merged

✨ Add fields on the organisation and poll forms #837

merged 36 commits into from
Feb 11, 2025

Conversation

bjlaa
Copy link
Contributor

@bjlaa bjlaa commented Feb 4, 2025

No description provided.

Copy link

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nosgestesclimat ✅ Ready (Inspect) Visit Preview Feb 11, 2025 3:55pm

@bjlaa bjlaa changed the base branch from preprod to NGC-1515 February 4, 2025 15:05
@bjlaa bjlaa requested a review from paulsouche February 4, 2025 15:05
Copy link

github-actions bot commented Feb 4, 2025

Report for the pull request #837


🌐 Translation status

UI's texts

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

FAQ's questions

Language Nb. missing translations Status
en Ø ✔️
es Ø ✔️

You will find more information about the translation in the dedicated file.

@Clemog
Copy link
Contributor

Clemog commented Feb 10, 2025

Je n'arrive pas à créer une campagne, c'est pas lié à cette carte j'imagine ?
image

@bjlaa bjlaa self-assigned this Feb 10, 2025
@bjlaa
Copy link
Contributor Author

bjlaa commented Feb 10, 2025

@Clemog oups je regarde

@bjlaa
Copy link
Contributor Author

bjlaa commented Feb 10, 2025

good @Clemog merci pour la recette

@Clemog
Copy link
Contributor

Clemog commented Feb 11, 2025

Ça fonctionne toujours pas chez moi

image

name,
expectedNumberOfParticipants: expectedNumberOfParticipants
? parseInt(expectedNumberOfParticipants)
: undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bien undefined et pas null par rapport aux discussions de ce matin ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça a changé depuis, regarde mon dernier commit

@@ -16,7 +16,7 @@ type Props = {

type Inputs = {
name: string
expectedNumberOfParticipants: number
expectedNumberOfParticipants: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi on est sur une string ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On récupère une string depuis l'input / react-hook-form

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu m'as donné l'idée d'une amélioration ! Next commit

@Clemog
Copy link
Contributor

Clemog commented Feb 11, 2025

Qques commentaires mais ça a l'air de fonctionner :)

Clemog
Clemog previously approved these changes Feb 11, 2025
Copy link
Contributor

@Clemog Clemog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manque juste une trad

@bjlaa bjlaa merged commit 7e36f42 into preprod Feb 11, 2025
4 of 5 checks passed
@bjlaa bjlaa deleted the NGC-1589 branch February 11, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants