sidestep nullable error #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address kotlin build error in flutter 3, issue incrediblezayed#32
|
@sshipman Seems this branch has conflict, can you fix? |
|
Yeah, but it's basically a one liner. It'll be quicker to reproduce the
fix in a new branch. I can't get to this for several hours (actual job)
…On Tue, May 17, 2022, 12:22 PM Katekko ***@***.***> wrote:
@sshipman <https://github.com/sshipman> Seems this branch has conflict,
can you fix?
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABA6P2NX2JLVCLH3IKTVRLVKPWXVANCNFSM5VWNZDGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
merge conflicts resolved. Please sanity check! |
|
@incrediblezayed @clong1995 May can you check for us? |
|
I will, but tbh, I did fix that specific issue in my latest commit itself |
Nice, thanks for your time. Maybe can you publish on the pub.dev? |
Yes I will, as soon as possible |
|
Hi, @incrediblezayed could you pls publish to pub.dev? This error prevents my app from building on android. Thank you for your time :) |
riberman
approved these changes
Jul 12, 2022
riberman
approved these changes
Jul 12, 2022
|
Hi, I'm so sorry, I'll check and update today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to Flutter 3, I started getting build errors as in issue #32. This was because the variable used was nullable, but the method required a non-nullable. We already had that! so I just use it directly.