Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: complete UIO implementation (resolves #149) #150

Merged
merged 7 commits into from
Jan 29, 2025
Merged

fix: complete UIO implementation (resolves #149) #150

merged 7 commits into from
Jan 29, 2025

Conversation

jobara
Copy link
Member

@jobara jobara commented Jan 28, 2025 •
edited
Loading

Resolves #149

  • Uses a customized version of UIO to remove the text-size and ToC preferences
  • Adds contrast theming of text selection
  • Handles line-height adjustments
  • Handles text-style adjustments
  • Handles enhance inputs adjustments

@jobara jobara marked this pull request as ready for review January 28, 2025 22:06
@jobara
Copy link
Member Author

jobara commented Jan 28, 2025

@chosww this PR is ready for review. Note we removed the ToC preference because most of the pages already include something like that.

chosww
chosww reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@chosww chosww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the link text decoration issue I found, things are working as expected.

src/assets/styles/base/_base.css Outdated
font-weight: var(--font-weight-semibold);
font-size: var(--fl-enhance-font-size);
font-weight: var(--fl-enhance-font-weight, var(--font-weight-semibold));
text-decoration: var(--fl-enhance-text-decoration);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes link underlines to not appear when enhanced-input is turned off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I've pushed up a fix.

@jobara jobara requested a review from chosww January 29, 2025 19:23
@chosww chosww merged commit 8aac85e into inclusive-design:dev Jan 29, 2025
2 checks passed
@incd-github-actions incd-github-actions bot mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chosww chosww chosww approved these changes

@greatislander greatislander Awaiting requested review from greatislander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete UIO implementation
2 participants
@jobara @chosww