PHP 8 and TYPO3 related updates #17 #23
Conversation
josefglatz
changed the title
|
Thx for your work Josef, I just added some comments to the code itself when you have some time for me :) |
|
@einpraegsam Hey Alex, where can I find your comments? |
| @@ -35,13 +36,14 @@ public function __construct(FeedRepository $feedRepository, TokenRepository $tok | |||
| /** | |||
| * @return void | |||
| */ | |||
| public function showAction() | |||
| public function showAction(): ResponseInterface | |||
There was a problem hiding this comment.
Just a question: Is this still ok for TYPO3 10? I'm asking because otherwise, we have to adjust the requirements.
There was a problem hiding this comment.
If it's ok I would leave it as-is and therefore remove the support for TYPO3 10. Since the extension looks like it's feature complete and TYPO3 v12 is coming I would suggest to support only v11 – if OK for you Alex!
I will update therefore the proper constraints.
There was a problem hiding this comment.
@einpraegsam would love to hear from you
There was a problem hiding this comment.
Yes, dropping support for 10 is fine also for me
No description provided.