Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position search-bar properly according to window #153

Merged
merged 2 commits into from
Nov 5, 2018
Merged

position search-bar properly according to window #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e2407a
position search-bar properly according to window
ralyodio Nov 5, 2018
c8ef6bf
remove extraneous comments
ralyodio Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->

## Screenshots (if appropriate):
39 changes: 35 additions & 4 deletions src/components/CategoriesMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,19 @@ export default {
justify-content: flex-start;
flex-grow: 0;
position: sticky;
top: 0;
top: -1px;
z-index: 1;
background-color: #131314;

> section {
display: flex;
justify-content: flex-start;
align-items: center;
overflow: hidden;

&.categories {
width: 66vw;
}
}

ul a {
Expand Down Expand Up @@ -230,14 +235,40 @@ export default {
}

@media (min-width: 480px) {
.topnav {
width: calc(100vw - 19rem);
}

.categories, .sub-categories {
width: calc(100vw - 19rem);

&.categories {
width: 40vw !important;
}
}
}

@media (min-width: 1200px) {
a.prev, a.next {
display: none !important;
@media (min-width: 800px) {
.categories, .sub-categories {
&.categories {
width: 60vw !important;
}
}
}

@media (min-width: 1024px) {
.categories, .sub-categories {
&.categories {
width: 66vw !important;
}
}
}

@media (min-width: 1440px) {
.categories, .sub-categories {
&.categories {
width: 75vw !important;
}
}
}
</style>
5 changes: 2 additions & 3 deletions src/components/SearchBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<form class="search-bar"
@submit.prevent="search()">
<input type="text"
placeholder="What are you looking for?"
placeholder="Search"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we increase the size of the search bar? Every other thing looks good to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to fit on mobile and this "What are you looking for?" is too big.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it overlay on click? So that we can have autocomplete for the search

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fit in on mobile and desktop better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont' think we should overlay the menu because then you can't click the "next" button for categories.

v-model="filter" />
<button>
<icon name="magnify" />
Expand Down Expand Up @@ -37,7 +37,6 @@ export default {
position: absolute;
top: 0;
right: 0;
display: none;
justify-content: flex-end;
align-items: center;

Expand All @@ -46,7 +45,7 @@ export default {
background: transparent;
color: #fff;
font-size: 1.6rem;
width: 26rem;
width: 10rem;
opacity: .6;

&::placeholder {
Expand Down