Fix test workflow and enable workflow runs in PRs from forks #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lseq into fix_workflows
schuenke
force-pushed
the
fix_workflows
branch
from
2a7fdb4 to
7e01d57
Compare
schuenke
force-pushed
the
fix_workflows
branch
from
7e01d57 to
af3d6ef
Compare
schuenke
changed the title
|
many thanks to @fzimmermann89 for the feedback and especially to @lrlunin for providing a great template for this workflow and for helping me test everything on my forked repo 🥇 The coverage comment will only be posted after this PR has been merged into master, but you can check schuenke#4 to see that it works even for PRs from a fork of a forked repo 😁 After the merge, the complete workflow will be available in every PR to this repo. |
fzimmermann89
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently blocks #235 and #240 , we should get it merged soon.
The test workflow is now splitted into two seperate workflows:
Furthermore, always all tests including sigpy a run. However, I left the matrix solution for with / without sigpy in case we experience sigpy problems again in the future. In the future, we might also want to add a coverage badge to our readme. I added the required step for this and just commented it out for the moment.