Feature: Campaign Page template #7761
Conversation
…emplate-GIVE-2250
|
@pauloiankoski I added you as a reviewer |
| public function loadTemplate($template) | ||
| { | ||
| if ( | ||
| 'give_campaign_page' === get_query_var('post_type') | ||
| && current_theme_supports('block-templates') | ||
| ) { | ||
| $template = $this->canRegisterBlockTemplate() | ||
| ? $template | ||
| : GIVE_PLUGIN_DIR . '/src/Campaigns/resources/views/campaign-page-template.php'; | ||
|
|
||
| return locate_block_template($template, 'campaign-page-template', ['campaign-page-template.php']); | ||
| } | ||
|
|
||
| return $template; | ||
| } |
There was a problem hiding this comment.
When hooking into template_include, we should first check if the user’s theme provides a template before falling back to our own. In this case, single-give_campaign_page.php should be prioritized if it exists in the theme.
There was a problem hiding this comment.
The whole purpose of this function is to load our template for themes that support FSE because they load a ton of stuff that we don't want to see on our campaign page. That's the point of this PR. Users can always change the layout from the editor if they don't like it. For sites that don't support FSE, the dev can create single-give_campaign_page.php and it will be loaded normally.
There was a problem hiding this comment.
This is an example of a theme without support for FSE. I thought that campaign-page-template.php would surface exactly in cases like that. It sounds like we are implementing it partially, so we’ll need to communicate that clearly to our users.
| .edit-post-visual-editor__post-title-wrapper { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Ideally, this should be in an editor stylesheet, but for now, it works to keep it within the CampaignTitle block since it is being loaded all the time.
There was a problem hiding this comment.
We use our title block only on campaign pages. This makes sense as it is loaded only on campaign pages.
There was a problem hiding this comment.
Yeah, but the styles are not being applied to the CampaignTitle block but to the page title element instead. That's what I meant.
Description
Registers a new campaign page template that will be used in themes that support FSE.
Also, the default Gutenberg title block is hidden and replaced with the Campaign title block.
Affects
Campaign page
Visuals
Testing Instructions
Install FSE theme
Create Campaign
Preview the campaign page on frontend
Edit site appearance
Pre-review Checklist
@unreleasedtags included in DocBlocks