Feature: Add Campaign Donations block #7703
Conversation
| /** | ||
| * @unreleased | ||
| */ | ||
| private function renderBlockHtml($donations): void |
There was a problem hiding this comment.
Oh man, I'm having a hard time reading this 😅
Why don't you move this into a separate file and then use the View class to load and render the file?
There was a problem hiding this comment.
This is a very WP way of doing these things and I have to say that I'm not a big fan 😁
There was a problem hiding this comment.
Really? I even tried to make it more object oriented, moving away from WP way of doing it.
There was a problem hiding this comment.
Let's discuss this more.
There was a problem hiding this comment.
Yeah, I don't like to mix PHP and HTML. I would love to see HTML in a separate file, and then you load it with the View helper class.
There was a problem hiding this comment.
Jon would like to see the template as being a React app.
| /** | ||
| * @unreleased | ||
| */ | ||
| if ( ! class_exists(CampaignDonationsBlockRenderer::class)) { |
There was a problem hiding this comment.
Why do we have to check if the class exists?
There was a problem hiding this comment.
Honestly, I didn't go much further on that but when in the Page Editor, I was receiving a fatal error from the block renderer saying that class was being registered multiple times.
There was a problem hiding this comment.
This is because the CampaignDonationsBlockRenderer is defined in the render.php file, and this file is included each time you include this block. The solution would be to move the class definition outside the render.php
There was a problem hiding this comment.
Refactored on 9392c10
pauloiankoski
force-pushed
the
feature/campaign-donations-block
branch
from
90390f7 to
4977ca5
Compare
Resolves GIVE-1393
Description
This pull request adds the Campaign Donations block, with options to show the top donations (by amount) or the recent donation (by date). This block is like a copy of the Campaign Donors block with some slightly changes on the visual but mainly in its query.
Visuals
Block Settings
Top donations and Recent donations
Empty state
Pre-review Checklist
@unreleasedtags included in DocBlocks