Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Campaign Cover Block #7701

Merged

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jan 31, 2025

Resolves GIVE-1505 / GIVE-1973

Description

  • Removes references of video support on the media Uploader from the campaign settings and creation modal.
    Slack conversation reference: https://lw.slack.com/archives/C04SLRDD9CK/p1738173558503109
  • Improved styles on the Uploader components.
  • Adds Campaign Cover Block to the block editor. This block's image can only be updated from the campaign settings. A placeholder will be displayed if no image is set from the campaign settings. The image supports alignment, resizing & duotone.

Affects

Campaign settings & Campaign Cover Block

Visuals

https://www.loom.com/share/b168317f31ef40ba9a3a1add7cea7b81?sid=70ad126a-bde3-476a-8b0f-31e9b76d5773

Testing Instructions

  • Add the campaign cover block without an image, verify a placeholder is displayed.
  • Add the campaign cover block with an image verify the image is can be resized, aligned and supports duotone. These blocks settings need to be verified on both the frontend page & in the admin editor.
  • Verify the UI/UX does not imply that videos can be supported from the block uploader.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Self Review of code and UX completed

Sorry, something went wrong.

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review January 31, 2025 04:25
@JoshuaHungDinh JoshuaHungDinh requested a review from alaca January 31, 2025 04:42
Copy link
Member

@alaca alaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @JoshuaHungDinh 👍

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed manual tests!

@JoshuaHungDinh JoshuaHungDinh merged commit 22bbb3b into epic/campaigns Feb 2, 2025
20 checks passed
@JoshuaHungDinh JoshuaHungDinh deleted the feature/campaign-cover-block-GIVE-1973 branch February 2, 2025 06:41
@jonwaldstein jonwaldstein mentioned this pull request Feb 17, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants