Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add new routes for donations and donors #7699

Open
wants to merge 43 commits into
base: epic/campaigns
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
e22047b
feature: add get routes for donations
glaubersilva Jan 28, 2025
a2d2695
tests: add test for donations pagination
glaubersilva Jan 28, 2025
74af706
tests: add more asserts
glaubersilva Jan 28, 2025
ebd4d57
tests: add GetDonationRouteTest class
glaubersilva Jan 28, 2025
6996169
feature: add get endpoints for donors
glaubersilva Jan 29, 2025
aaecb8a
tests: add GetDonorRouteTest class
glaubersilva Jan 29, 2025
7505388
tests: add testGetDonorsWithPagination method
glaubersilva Jan 29, 2025
0850304
refactor: change permissions callback
glaubersilva Jan 29, 2025
df1697b
refactor: tweaks and polishments
glaubersilva Jan 29, 2025
a1900dd
tests: tweak property comments
glaubersilva Jan 29, 2025
5a1bb94
fix: wrong rest_url path
glaubersilva Jan 29, 2025
bfe2a6f
refactor: restrict access to sensitive data
glaubersilva Jan 30, 2025
4dcb2d2
refactor: uncomment code
glaubersilva Jan 30, 2025
7a086f5
refactor: add where conditions for donation mode and status
glaubersilva Jan 30, 2025
4fca5af
refactor: use query method
glaubersilva Jan 30, 2025
0aa85a1
refactor: remove unnecessary distinct clause
glaubersilva Jan 30, 2025
3ada42b
feature: add hideAnonymousDonations parameter
glaubersilva Jan 30, 2025
8ad5a7d
refactor: remove unnecessary select
glaubersilva Jan 30, 2025
205d1a1
refactor: improve query readability and consider status and payment mode
glaubersilva Jan 30, 2025
811a6a2
feature: add hideAnonymousDonors parameter
glaubersilva Jan 30, 2025
9a8a324
fix: broken unit tests
glaubersilva Jan 30, 2025
7e83d0d
feature: add onlyWithDonations param
glaubersilva Jan 30, 2025
e57c51e
doc: add comment
glaubersilva Jan 30, 2025
4ae26ea
refactor: remove unnecessary distinct
glaubersilva Jan 30, 2025
c64e98c
refactor: add sort and direction parameters
glaubersilva Jan 30, 2025
7aa9903
tests: add testGetDonorsSortedByTotalAmountDonated method
glaubersilva Jan 31, 2025
7fee060
tests: add sortableColumnsDataProvider and refactor test to use it
glaubersilva Jan 31, 2025
e0c0cc3
tests: simplify logic
glaubersilva Jan 31, 2025
b54e0b4
tests: add testGetDonorsShouldReturnSensitiveData method
glaubersilva Jan 31, 2025
783655b
tests: add new tests for the onlyWithDonations param
glaubersilva Jan 31, 2025
e3eb167
tests: add testGetDonationsShouldReturnSensitiveData method
glaubersilva Jan 31, 2025
bf7214a
refactor: simplify query
glaubersilva Jan 31, 2025
563a726
tests: add testGetDonationsSortedByColumns
glaubersilva Jan 31, 2025
ca5c7a7
refactor: replace validate_callback with enum
glaubersilva Jan 31, 2025
9fd33ff
refactor: change default sort direction
glaubersilva Jan 31, 2025
b508a7f
tests: change helper method names
glaubersilva Jan 31, 2025
35dc9ca
refactor: remove distinct
glaubersilva Jan 31, 2025
ed34c89
refactor: add mode parameter
glaubersilva Feb 7, 2025
ded974c
refactor: replace hideAnonymousDonations with includeAnonymousDonations
glaubersilva Feb 7, 2025
b241027
tests: rename helper methods
glaubersilva Feb 7, 2025
74d8d6e
refactor: change the routes namespace for donors, donations, and camp…
glaubersilva Feb 14, 2025
7def493
refactor prevent access to "anonymous data"
glaubersilva Feb 14, 2025
238fd0a
tests: add new methods to check anonymous data return
glaubersilva Feb 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove unnecessary distinct
glaubersilva committed Jan 30, 2025
commit 4ae26eab83f64597b147d5c798a48fdea015a921
3 changes: 1 addition & 2 deletions src/Donors/Controllers/DonorRequestController.php
Original file line number Diff line number Diff line change
@@ -66,8 +66,7 @@ public function getDonors(WP_REST_Request $request): WP_REST_Response

if ($request->get_param('hideAnonymousDonors')) {
// Exclude anonymous donors from results - Donors only can be excluded if they made an anonymous donation
$query->distinct()
->join(function (JoinQueryBuilder $builder) {
$query->join(function (JoinQueryBuilder $builder) {
$builder->innerJoin('give_donationmeta', 'donationmeta4')
->joinRaw("ON donationmeta4.meta_key = '" . DonationMetaKeys::ANONYMOUS . "' AND donationmeta4.meta_value = 0 AND donationmeta4.donation_id = donationmeta1.donation_id");
});