Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ListTable configuration #7678

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

alaca
Copy link
Member

@alaca alaca commented Jan 16, 2025

Description

This pull request includes changes to support the configuration of SWR options in the ListTableApi class. We need this so that we can set the revalidateOnFocus SWR option to false to prevent list table reloads.

Affects

ListTableApi class

Testing Instructions

Go to the campaign page - Forms tab
Then select the Settings tab, and then select the Forms tab again

The forms list table should not reload

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Self Review of code and UX completed

@alaca alaca requested review from glaubersilva and pauloiankoski and removed request for glaubersilva January 16, 2025 12:04
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it works as expected. Nice job!

Copy link
Member

@rickalday rickalday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed QA tests.

@alaca alaca merged commit 74b417f into epic/campaigns Feb 3, 2025
20 checks passed
@alaca alaca deleted the feature/list-table-config-GIVE-2036 branch February 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants