Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant require of ifrit #236

Merged
merged 2 commits into from
May 13, 2019
Merged

remove redundant require of ifrit #236

merged 2 commits into from
May 13, 2019

Conversation

mamantoha
Copy link
Contributor

@mamantoha mamantoha commented May 12, 2019

Hi.

It's not necessary here :)

In "ifrit" you have the class called HashWithIndifferentAccess, which triggers a Crystal bug, it unable to compile jennifer.cr with raven.cr - Sija/raven.cr#49.

I guess HashWithIndifferentAccess not used in this shard.

@mamantoha mamantoha changed the title remove redundant require of ifrit [WIP] remove redundant require of ifrit May 12, 2019
@mamantoha mamantoha changed the title [WIP] remove redundant require of ifrit remove redundant require of ifrit May 12, 2019
@imdrasil imdrasil self-requested a review May 13, 2019 07:34
@imdrasil imdrasil merged commit 2910310 into imdrasil:master May 13, 2019
@mamantoha mamantoha deleted the remove-redundant-require-ifrit branch May 13, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants